Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeAddModal to make JSON values less concerning #921

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 23, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

  • "Object" values should be actually called "JSON" values
  • "JSON" value should not be a default, I'm not sure why we're actually switching to JSON every time someone wants to provide a value
  • Attribute preview should be rendered always by reusing existing components, not only for Rich attributes. In addition, right now JSON values are not parsed at all and they're passed to preview as strings

Related with #907

Before change it looks like that:

image

What is the new behaviour?

After change it will look like that:

image

@psrok1 psrok1 force-pushed the fix/attribute-add-modal-object branch from 03f23aa to f49e556 Compare February 27, 2024 13:12
@psrok1 psrok1 marked this pull request as ready for review February 27, 2024 18:02
@psrok1 psrok1 merged commit 572dde9 into master Feb 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant